revamp pool API #315
Merged
revamp pool API #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is super, so much nicer API! :D |
Member
Author
|
still need to grapple with CI but review / feedback is welcome at this point. I think it's easiest to read through the API docs and examples and just try it out |
Contributor
|
One thing I noticed, is the support for thumb v6 dropped? |
Member
Author
|
I didn't have time to look into that. CAS semantics does not produce a sound treiber stack because of the ABA problem; you need LL/SC intrinsics for a sound implementation (see #180). I don't know if the stack would be sound with pseudo (non-lock-free) CAS wrapped in a critical section. |
Contributor
|
Hmm that's unfortunate, using it (even with critical sections) was a nice feature do it worked anywhere. I don't have time to review everything right now, but I'll have a look soon :) |
tsan does not support the 32-bit x86 targets
Member
Author
|
bors merge |
Contributor
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #286
closes #167
closes #318