Skip to content

bus: Adding AtomicDevice for I2C and SPI bus sharing in multiple interrupt contexts #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2024
Merged

bus: Adding AtomicDevice for I2C and SPI bus sharing in multiple interrupt contexts #593

merged 3 commits into from
Apr 23, 2024

Conversation

@Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Apr 23, 2024 •
edited
Loading

based on #579 by @ryan-summers.

  • Squashed
  • Use a global busy flag for the whole bus, not one per device (soundness fix)
  • Expand docs a bit.

commits:

  • Adding AtomicDevice for I2C bus sharing
  • bus: make AtomicDevice use a per-bus "busy" flag, not per-device.
  • bus: expand docs for AtomicDevice a bit.

@Dirbaio Dirbaio requested a review from a team as a code owner April 23, 2024 19:43
@Dirbaio Dirbaio mentioned this pull request Apr 23, 2024
Closed
eldruin
eldruin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 1d33458 Apr 23, 2024
@Tschrock Tschrock mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dirbaio @eldruin @ryan-summers