Skip to content

Add example of opaque CountDown type usage #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add example of opaque CountDown type usage #109

wants to merge 3 commits into from

Conversation

@thenewwazoo
Copy link
Contributor

@thenewwazoo thenewwazoo commented Nov 7, 2018

This PR adds a small doc update to illustrate how to permit using the start function of the CountDown trait when writing a driver.

therealprof
therealprof reviewed Nov 7, 2018
View reviewed changes
@thenewwazoo
Copy link
Contributor Author

thenewwazoo commented Nov 8, 2018

Got rid of the .gitignore line, should be gtg.

therealprof
therealprof reviewed Nov 8, 2018
View reviewed changes
therealprof
therealprof approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

therealprof
therealprof requested changes Nov 8, 2018
View reviewed changes
@Disasm
Copy link
Member

Disasm commented Feb 22, 2019

bors retry

@mathk mathk added S-waiting-on-author Author needs to make changes to address reviewer comments and removed S-waiting-on-author Author needs to make changes to address reviewer comments labels Feb 25, 2019
@mathk
Copy link

mathk commented Feb 25, 2019

bors try

bors bot added a commit that referenced this pull request Feb 25, 2019
@bors
Try #109:
4c3ad35
@bors
Copy link
Contributor

bors bot commented Feb 25, 2019

try

Build succeeded

@mathk mathk added the S-waiting-on-author Author needs to make changes to address reviewer comments label Feb 25, 2019
@mathk mathk requested a review from therealprof February 25, 2019 14:29
@mathk mathk added S-waiting-on-review Review is incomplete and removed S-waiting-on-author Author needs to make changes to address reviewer comments labels Feb 25, 2019
@eldruin
Copy link
Member

eldruin commented Jul 15, 2020

LGTM!
@thenewwazoo could you rebase this to master?

@eldruin eldruin added this to the v1.0.0 milestone Jul 15, 2020
@eldruin eldruin removed this from the v1.0.0 milestone Feb 14, 2022
@therealprof
Copy link
Contributor

therealprof commented Jun 3, 2025

Unfortunately this has staled out so after some consideration we're going to close this.

@therealprof therealprof closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

@thejpster thejpster Awaiting requested review from thejpster

@therealprof therealprof Awaiting requested review from therealprof

Assignees

No one assigned

Labels

S-waiting-on-review Review is incomplete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thenewwazoo @Disasm @mathk @eldruin @therealprof