Skip to content

Fix CI compiletest breakage due to Rust 1.63 #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

Fix CI compiletest breakage due to Rust 1.63 #450

merged 1 commit into from
Aug 12, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Aug 12, 2022

No description provided.

@Dirbaio Dirbaio requested a review from a team as a code owner August 12, 2022 00:12
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Aug 12, 2022
adamgreig
adamgreig approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would break the MSRV tests, but it turns out we already only run the compiletest tests on stable, not MSRV or nightly.

bors r+

@adamgreig adamgreig mentioned this pull request Aug 12, 2022
Merged
1 task
@bors
Copy link
Contributor

bors bot commented Aug 12, 2022

Build succeeded:

@bors bors bot merged commit e46e231 into rust-embedded:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dirbaio @rust-highfive @adamgreig