Fix #414, use fully qualified path for exception enum in #[exception] macro
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts rust-embedded/cortex-m-rt#224 to continue to use a fully-qualified path to `exception`.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
thalesfragoso
approved these changes
Jan 27, 2022
Member
thalesfragoso
left a comment
thalesfragoso
left a comment
There was a problem hiding this comment.
Great, thanks again!
bors r+
Contributor
yvt
added a commit
to r3-os/r3
that referenced
this pull request
Jun 8, 2022
These macros are no longer usable by fully-qualified paths after [rust-embedded/cortex-m-rt#224][1]. Although this change was later partially reverted by [rust-embedded/cortex-m#416][2], the version that includes this fix is not released yet. [1]: rust-embedded/cortex-m-rt#224 [2]: rust-embedded/cortex-m#416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts rust-embedded/cortex-m-rt#224
to continue to use a fully-qualified path to
exception.