This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Make it unsafe to define NMI handlers #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns to panic" This reverts commit 6f524bd.
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
jonas-schievink
commented
Aug 23, 2020
This is unsound unless you control the panic handler implementation.
therealprof
suggested changes
Aug 23, 2020
|
We're missing all the changelog entries. I'll add one to #288 to avoid merge conflicts. |
therealprof
approved these changes
Aug 23, 2020
|
bors r=therealprof |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #257
Fixes #269
Fixes rust-embedded/cortex-m#196 (see that thread for details)