-
Notifications
You must be signed in to change notification settings - Fork 10
Created new Humidity and Density modules #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pukeko37
commented
Apr 27, 2020
* Responded to Issue #19 - added humidity module * Created density module (required for one output from Humidity) * Updated ReadMe to include Density and Humidity * Added new modules into lib.rs * [TODO: updates to CHANGELOG, etc...] [TODO (Possibly): Add more native units (g/m3), (kg/L), (g/mL), (t/m3), (oz/cu in), (oz/US fl oz), (lb/cu yd)... ]
@eldruin should this also be reviewed? It has been here quite a long time.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the chances of this getting merged? I am implementing a sensor driver which would need the temperature and humidity structs and would prefer to use this library for both! |
Co-authored-by: Diego Barrios Romero <[email protected]>
Co-authored-by: Diego Barrios Romero <[email protected]>
Sorry about the delay. I submitted the PR over a year ago and got no response for a long time. It was supposed to be a quick PR to get changes I needed upstream, so I could use the crate in my app. I didn't even put my changes in a new feature branch. In the end, because I got no response from the maintainers, I put my changes in my own private library. So, I lost interest in helping ... Anyway. I've responded to the maintainers. Up to them now. |
Added changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about initially not getting a response. This project has now been transferred to an umbrella org.
The changes look good to me. Just a nitpick about the changelog left and it would be ready for merge.
Co-authored-by: Diego Barrios Romero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@pukeko37 could you rebase this against master? GitHub is complaining about conflicts. |
I just noticed, The README.md has a list of modules in it. Not updated with humidity and density. |
I thought I did rebase it. I've been editing in GitHub. I don't have a local dev environment. |
I think that's done it, but I'm not sure. Please let me know |
GitHub still shows conflicts. I'm not sure which, though. |
When I try to fetch upstream, my fork repository says: This branch is not behind the upstream rust-embedded-community:master. Not sure what I need to do. |
This PR also says: "This branch has no conflicts with the base branch". |
Ok I was able to rebase and merge these changes manually to the current master. |