Impl Ord and PartialOrd for RecoverableSignature

[benthecarman]

No description provided.

[apoelstra]

Do you need the ordering to be consistent between LE and BE machines? If so, you probably need to serialize them before comparing, #derive will do the wrong thing. (We probably should fix this in ffi::RecoverableSignature actually.)

[benthecarman]

Do you need the ordering to be consistent between LE and BE machines? If so, you probably need to serialize them before comparing, #derive will do the wrong thing. (We probably should fix this in ffi::RecoverableSignature actually.)

Yeah that'd be ideal. How do I do that?

[apoelstra]

Yeah that'd be ideal. How do I do that?

See for example what we did with the regular signatures: https://github.com/rust-bitcoin/rust-secp256k1/blob/master/secp256k1-sys/src/lib.rs#L278-L286

That's in secp256k1-sys, the FFI lib. Then in the main library you can just #derive it like you're doing now.

[benthecarman]

@apoelstra sorry never got to this, but looks like they already exist

rust-secp256k1/secp256k1-sys/src/recovery.rs

Line 76 in 3373cc9

impl Ord for RecoverableSignature {

[Kixunil]

@benthecarman did you mean to close the PR?

[apoelstra]

@Kixunil no, it should be merged :). This PR is about deriving the ordering traits on the rust-secp repo. I had said that we couldn't derive these since it would pass thorugh to the rust-secp-sys ordering traits, which were implementation defined. But actually they aren't implementation-defined and there is no problem.

[apoelstra]

ACK dbc5465 oops, sorry!

[Kixunil]

Oh, I thought this one does the same thing as the linked code but the linked is on -sys and this one is in non--sys.