Using serde/alloc and serde/std with corresponding features

[dr-orlovsky]

No description provided.

[real-or-random]

Concept ACK

[elichai]

LGTM

[dr-orlovsky]

It will be nice to get it merged to complete no_std support. How many ACKs do we need for this? @TheBlueMatt

[devrandom]

are we missing some CI tests to catch these things?

[dr-orlovsky]

@devrandom we need cross-lib integration CI (impossible with GitHub) for that I assume

[devrandom]

@devrandom we need cross-lib integration CI (impossible with GitHub) for that I assume

Actually, I'm confused now. If this works in practice (not test failures, no failures in rust-bitcoin that depends on it), then it probably means that we don't actually use anything from serde that is gated by std or alloc. If that's the case, then isn't it up to whatever crate that depends on this one to pull in features from serde that it needs, if it needs them?

[elichai]

Let me take back my ACK, it seems to me that this library never needs serde for the alloc/std stuff, so I don't see a reason why we should enable those features.
if downstream crates use serde by themselves they should import it and enable the features they need.

(that's also part of the reason why no tests "failed" here)

explained in the comment above

[apoelstra]

Closing as the value proposition is unclear and this seems stale.