Latest release (0.5.0) does not work on WASM & `test.sh`is broken

[thomaseizinger]

Investigations on why CI is failing downstream showed that the web-assembly build for that PR actually never worked: https://github.com/rust-bitcoin/rust-secp256k1/runs/5470259221?check_suite_focus=true#step:5:518

For reference, even after the latest changes to the CI config, it is still not working: https://github.com/rust-bitcoin/rust-secp256k1/runs/5517459899?check_suite_focus=true#step:5:2447

[sanket1729]

I do not understand anything about wasm, but I can confirm that DO_WASM=true ./contrib/test also does not work locally.

[thomaseizinger]

I do not understand anything about wasm, but I can confirm that DO_WASM=true ./contrib/test also does not work locally.

Yes, annoyingly though, it does not exit with a non-zero exit code which is why CI does not pick up the failure.

cc @tcharding

[tcharding]

Leave it with me, I'll (EDIT: try to) sort it out.

[tcharding]

Its got me beat I'm afraid. Here is a draft (non-mergable) PR showing the little I found: #421

[tcharding]

This one is proving to be a bit curly.

• Improve CI script #420 is preparation for futher fixes.
• Fix wasm build #421 is a fix to the WASM build failure described in this issue but leaves the WASM tests failing still.
• Fix test script silent failure #422 resolves the test.sh problems described in this issue
• Combine PRs for ease of merging #423 combines the three PRs above to see if things are actually fixed (spoiler: they are not :)

Any tips, suggestions, or ideas please?

[junderw]

I get this error starting with 0.22.0 (maybe it gives us a hint?):

Expand

error: linking with `rust-lld` failed: exit status: 1
  |
  = note: rust-lld: error: duplicate symbol: WASM32_INT_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_INT_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_INT_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_INT_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_SIZE_T_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_SIZE_T_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_CHAR_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_CHAR_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_PTR_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_PTR_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult_gen.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          
          rust-lld: error: duplicate symbol: WASM32_INT_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_INT_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_INT_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_INT_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_SIZE_T_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_SIZE_T_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_CHAR_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_UNSIGNED_CHAR_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_PTR_SIZE
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)
          
          rust-lld: error: duplicate symbol: WASM32_PTR_ALIGN
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(precomputed_ecmult.o)
          >>> defined in /tmp/rustciBlixx/libsecp256k1_sys-b664e02e63969bc9.rlib(secp256k1.o)

[junderw]

Perhaps including precomputed_ecmult.c AND precomputed_ecmult_gen.c in the build is causing the problem.

[thomaseizinger]

Perhaps including precomputed_ecmult.c AND precomputed_ecmult_gen.c in the build is causing the problem.

That is what upstream does too though and it is fine, at least from what I can see from the Makefile.

The error originates from symbols that we add in our buildscript to make it wasm compatible.

Perhaps we no longer need the symbols altogether?

[junderw]

I made #426 which seems to help.