Skip to content

Support conversion of multi-Xprivs into multi-Xpubs #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Support conversion of multi-Xprivs into multi-Xpubs #757

merged 2 commits into from
Oct 17, 2024

Conversation

@shesek
Copy link
Contributor

@shesek shesek commented Oct 17, 2024

Possible when all hardened derivation steps are shared among all paths (or if there are none). Errors otherwise.

@shesek
Support conversion of multi-Xprivs into multi-Xpubs
7d3e1e8 
Possible when all hardened derivation steps are shared among all paths
(or if there are none). Errors otherwise.
@shesek shesek force-pushed the 202410-multi-xpriv-to-pub branch from 93a71d7 to 7d3e1e8 Compare October 17, 2024 00:30
apoelstra
apoelstra previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7d3e1e8; successfully ran local tests; the stringly-typed errors are OK since this module is full of them

@apoelstra
Copy link
Member

apoelstra commented Oct 17, 2024

Would like @sanket1729 to take a quick look at this before acking to sanity-check it.

In particular this forbits multixpubs where there are hardened derivations after the split. I assume this is a requirement to be a legal multixpub? Because there isn't any obvious reason we should be forced to have this limit.

@shesek
Copy link
Contributor Author

shesek commented Oct 17, 2024 •
edited
Loading

assume this is a requirement to be a legal multixpub? Because there isn't any obvious reason we should be forced to have this limit.

Correct, this is a limitation imposed by the current DescriptorMultiXKey structure (can only have one concrete pubkey as the base for derivations) and not something inherent. But supporting it would require some pretty invasive changes and it seemed to me that in the typical case hardened derivation steps are usually shared, and that it can be useful even with that limitation.

@shesek
Copy link
Contributor Author

shesek commented Oct 17, 2024 •
edited
Loading

Added another commit with some formatting changes that also updates the existing DescriptorXKey::to_public(). Let me know if you'd like me to squash or drop it.

sanket1729
sanket1729 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sanket1729
sanket1729 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ae64ce6

apoelstra
apoelstra approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ae64ce6; successfully ran local tests; the stringly-typed errors are OK since this module is full of them

shesek added a commit to shesek/minsc that referenced this pull request Oct 17, 2024
@shesek
keys: Support conversion of multi-Xprivs into multi-Xpubs
7cdd31b 
And add a simple example using it (https://min.sc/v0.3/#github=examples/taproot-psbt-multipath-simple)

Implemented in an extension trait, pending rust-bitcoin/rust-miniscript#757.
@apoelstra apoelstra merged commit 33b417b into rust-bitcoin:master Oct 17, 2024
29 of 30 checks passed
shesek added a commit to shesek/minsc that referenced this pull request Oct 18, 2024
@shesek
keys: Support conversion of multi-Xprivs into multi-Xpubs
d5a6d6a 
And add a simple example using it (https://min.sc/v0.3/#github=examples/taproot-psbt-multipath-simple)

Implemented in an extension trait, pending rust-bitcoin/rust-miniscript#757.
shesek added a commit to shesek/minsc that referenced this pull request Oct 18, 2024
@shesek
keys: Support conversion of multi-Xprivs into multi-Xpubs
cd725d8 
Implemented in an extension trait, pending rust-bitcoin/rust-miniscript#757.
heap-coder added a commit to heap-coder/rust-miniscript that referenced this pull request Sep 27, 2025
@heap-coder
Merge rust-bitcoin/rust-miniscript#757: Support conversion of multi-X…
b61a648 
…privs into multi-Xpubs

ae64ce617d0e1bed0e25edda1fa13108c37e27c0 Some minor formatting changes (Nadav Ivgi)
7d3e1e846ce75c86af3fed79300df5ce6247d404 Support conversion of multi-Xprivs into multi-Xpubs (Nadav Ivgi)

Pull request description:

  Possible when all hardened derivation steps are shared among all paths (or if there are none). Errors otherwise.

ACKs for top commit:
  sanket1729:
    utACK ae64ce617d0e1bed0e25edda1fa13108c37e27c0
  apoelstra:
    ACK ae64ce617d0e1bed0e25edda1fa13108c37e27c0; successfully ran local tests; the stringly-typed errors are OK since this module is full of them

Tree-SHA512: 47d90831409b538d6b521b354696a5ed459eb45a036938d1f6fd59dca66254115abe65bca861de3428b285c0cbf7ae3591779cfdd6be0a2dc12b3b967e221b2d
loop-ghost5rty added a commit to loop-ghost5rty/minsc that referenced this pull request Sep 28, 2025
@loop-ghost5rty
keys: Support conversion of multi-Xprivs into multi-Xpubs
7116595 
Implemented in an extension trait, pending rust-bitcoin/rust-miniscript#757.
@oleonardolima oleonardolima mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shesek @apoelstra @sanket1729