feat: add MaxBareScriptSizeExceeded err for bare consensus check #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ceeded err for bare consensus check
834bd3dcc9bbcecd8603d85fc17ddb82f2d4ba65 feat: add MaxBareScriptSizeExceeded err for bare consensus check (ChrisCho-H)
Pull request description:
`BareCtx` consensus validity check returns `MaxWitnessScriptSizeExceeded` err when exceeding script size limit, which is wrong and confusing. Adding `MaxBareScriptSizeExceeded` and using it instead can clearly give a correct message on compile error.
ACKs for top commit:
apoelstra:
ACK 834bd3dcc9bbcecd8603d85fc17ddb82f2d4ba65; successfully ran local tests; Yeah, this seems like a good idea
Tree-SHA512: 4dae0617bdaf1aee7ffd74875471a9dc550b4e3fdd4499894d4172c047f8dbf8b3ca5dff92868999f2ed0356400b9327003b6ac249cd428606204dc5f0506c04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BareCtxconsensus validity check returnsMaxWitnessScriptSizeExceedederr when exceeding script size limit, which is wrong and confusing. AddingMaxBareScriptSizeExceededand using it instead can clearly give a correct message on compile error.