Remove fixed TODO #520
Merged
Remove fixed TODO #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This TODO was actually from 255 where the bug was in cast_unlikely, even though the issue is labbelled with or_i (my bad for not checking). There is no code for `cast_unlikely` as it treated as or_i. Addressed in 239efd5
apoelstra
approved these changes
Jan 18, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
cf0578798e2d774b41f5c8b72628c539ea9e2a6a Remove fixed TODO (sanket1729)
Pull request description:
This TODO was actually from 255 where the bug was in cast_unlikely, even though the issue is labeled with or_i (my bad for not checking). There is no code for `cast_unlikely` as it is treated as or_i.
Addressed in 239efd55387f1d893e6ac4e602ca11454785c375
Fixes #268
ACKs for top commit:
apoelstra:
ACK cf0578798e2d774b41f5c8b72628c539ea9e2a6a
Tree-SHA512: c55236979dfaac3e104edd35eb191be20fe45b6e994a886603d9b9c5559f49723fdaa10f73eaee7e7d6f30170f948f609e0369cd65c3569585675d432661f74a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This TODO was actually from 255 where the bug was in cast_unlikely, even though the issue is labeled with or_i (my bad for not checking). There is no code for
cast_unlikelyas it is treated as or_i.Addressed in 239efd5
Fixes #268