Fix TapTree depth check bug #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
tACK aeebccd |
apoelstra
previously approved these changes
Jun 9, 2022
There are two bugs fixed in this commit 1) Not checking height while creating tree from from_str/from_tree 2) Fix height calculation bugs with root at 0
Member
Author
|
Rebased after #426 was merged |
apoelstra
approved these changes
Jun 10, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
61389dcba850a64f805a8b85afc927f964cfcec8 Fix tr tree checking bug (sanket1729)
Pull request description:
As spotted in #317
ACKs for top commit:
apoelstra:
ACK 61389dcba850a64f805a8b85afc927f964cfcec8
Tree-SHA512: cef0169dcc18bd1d69b0338fc12a9c75451a314f22271bdb7ef7f533aa695434cc9e8832a28f2be2dc35c647028863bc9faa1e21449029e7917284c102651916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in #317