Add the missing file for testing miniscripts #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving from integration tests repo to `cargo test`, I forgot to add the test file for miniscript tests from cpp.
Initially setup tests were run once per each integration test. This makes it run only once
sanket1729
force-pushed
the
int_test_fixups
branch
from
39c9c83 to
1ab637f
Compare
apoelstra
approved these changes
Jun 9, 2022
Member
|
Lol, oops, good catch. |
Member
Author
|
You Acked a different commit, but I took the liberty to merge this as it was only adding test code. |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ing miniscripts 1ab637f86d16cfb0708c263858b243d8e8eb91b7 Move setup tests to a single test (sanket1729) 67c38e8dd06af1bf1f720d346f004ccfc1eed4c8 Add the missing file for testing miniscripts (sanket1729) Pull request description: When moving from integration tests repo to `cargo test`, I forgot to add the test file for miniscript tests from cpp. Top commit has no ACKs. Tree-SHA512: 9e762c3b208a2fd2ae35ebc743641e8cbda534e4e30ef8d20050a8db594f102355eb189940902e9b47be2879c3ea5dee769de1720f9443cc23abe55ae1aa92bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving from integration tests repo to
cargo test, I forgot toadd the test file for miniscript tests from cpp.