Add support for running integration tests via cargo test #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future commits will remove the hacky integration test setup. There are still some annoying warnings present for ununsed functions when they are really used. rust-lang/rust#46379 Disambiguiate rand feature with dev dependancy https://users.rust-lang.org/t/features-and-dependencies-cannot-have-the-same-name/47746
sanket1729
force-pushed
the
int_test_rework
branch
from
3864ae4 to
139324a
Compare
RCasatta
reviewed
May 27, 2022
|
|
||
| #[test] | ||
| fn tests_from_cpp() { | ||
| let cl = &setup::setup().client; |
Contributor
There was a problem hiding this comment.
I am a little puzzled in understanding how this test could work, since once BitcoinD struct goes out of scope, the node is stopped
Member
Author
There was a problem hiding this comment.
setup returns BitcoinD. It never goes out of scope.
RCasatta
reviewed
May 27, 2022
| [dev-dependencies] | ||
| bitcoind = {version = "0.26.1", features=["22_0"]} | ||
| actual-rand = { package = "rand", version = "0.8.4"} | ||
| bitcoin = { version = "0.28", features = ["rand"]} |
Contributor
There was a problem hiding this comment.
since there is rand anyway, can't we use sign_schnorr_with_aux_rand and remove the feature rand so that we don't have both bitcoin and bitcoin-with-rand?
Member
Author
There was a problem hiding this comment.
Adressing in a follow-up PR.
apoelstra
approved these changes
May 27, 2022
Member
There was a problem hiding this comment.
ACK 139324a
I did not read the code as carefully as Riccardo evidently did -- but on a light reading it all looks good (or at least, it all looks like it does integration testing and looks like it's confined to test-only parts of the codebase, and it succeeded on my local CI).
apoelstra
added a commit
that referenced
this pull request
Jun 3, 2022
92050de Remove bitcoin rand feature from integration testing (sanket1729) Pull request description: Addresses [feedback ](#420 (comment)) #420 's review ACKs for top commit: apoelstra: ACK 92050de RCasatta: ACK 92050de Tree-SHA512: ad3dcc3631eb3ffd6de30d577d8a08756cbb4a2ff1670b21f4902422a2104bbfc8b161583a1ba3dd7368160e2dd51bac1d68c9332fc73a3a72d3c6b3ddcdabb4
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ration tests via cargo test 139324a641d364e6c5f5c3659d81c937da7a935c Remove integration test code (sanket1729) 90b5f10d4343c61c9c3630770bba7d6f21143406 Remove warnings (sanket1729) 967b95e2e1ff4122c44e7b5d041cbeca5e7b897d Add support for running integration tests via cargo test (sanket1729) Pull request description: There are still some annoying warnings present for unused functions when they are used. rust-lang/rust#46379 Later commits will remove the hacky integration test setup. Running `cargo test` now should also run integration tests Our testing infrastructure now takes a long time to build because we have more than 100 dependencies (transitive). But all of these are dev dependencies, so our library isn't getting bloated. Fixes #361 ACKs for top commit: apoelstra: ACK 139324a641d364e6c5f5c3659d81c937da7a935c Tree-SHA512: debf68fd0ac98cffa9c8c89964d6d1c45ee542fe17eb2fdab6295357efc06eb43a0412e6ed5d0fd7264a987989984eebb0c5b3bbf7169ecb780d31dce887cb0b
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…rom integration testing 92050de167119f3d6ed4d60451e7925d11121dd4 Remove bitcoin rand feature from integration testing (sanket1729) Pull request description: Addresses [feedback ](rust-bitcoin/rust-miniscript#420 (comment)) #420 's review ACKs for top commit: apoelstra: ACK 92050de167119f3d6ed4d60451e7925d11121dd4 RCasatta: ACK 92050de167119f3d6ed4d60451e7925d11121dd4 Tree-SHA512: ad3dcc3631eb3ffd6de30d577d8a08756cbb4a2ff1670b21f4902422a2104bbfc8b161583a1ba3dd7368160e2dd51bac1d68c9332fc73a3a72d3c6b3ddcdabb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some annoying warnings present for unused functions when they are used.
rust-lang/rust#46379
Later commits will remove the hacky integration test setup.
Running
cargo testnow should also run integration testsOur testing infrastructure now takes a long time to build because we have more than 100 dependencies (transitive). But all of these are dev dependencies, so our library isn't getting bloated.
Fixes #361