Use KeySource instead of tuple #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy emits: warning: very complex type used. Consider factoring parts into `type` definitions The type we return is more complex than needed because we do not use the `bip32::KeySource` alias but instead write the full tuple `(byp32::Fingerprint, bip32::DerivationPath)`. To fix the clippy warning we have at least 3 options 1. Add an alias for the complex return type 2. Add a compiler directive to quieten clippy 3. Use `bip32::KeySource` instead of tuple (1) seems like an overkill (2) means we loose lint coverage for the whole function Elect to do (3), the best of 3 imperfect solutions.
tcharding
force-pushed
the
05-10-use-key-source
branch
from
ae1eff5 to
f8945d0
Compare
Member
Author
Oh yeah? Why is that? At some other place in some other time I favoured the tuple also because I thought it was clearer than |
Member
|
"keysource" is a standard term (I believe) for this tuple, so by using the shorter name it aids readability. |
Member
Author
|
cool, cheers. |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
f8945d05d82b90456fc68812f53807b690a5ab1e Use KeySource instead of tuple (Tobin C. Harding)
Pull request description:
Clippy emits:
warning: very complex type used. Consider factoring parts into `type` definitions
The type we return is more complex than needed because we do not use the `bip32::KeySource` alias but instead write the full tuple `(byp32::Fingerprint, bip32::DerivationPath)`.
To fix the clippy warning we have at least 3 options
1. Add an alias for the complex return type
2. Add a compiler directive to quieten clippy
3. Use `bip32::KeySource` instead of tuple
(1) seems like an overkill
(2) means we loose lint coverage for the whole function
Elect to do (3), the best of 3 imperfect solutions.
ACKs for top commit:
apoelstra:
ACK f8945d05d82b90456fc68812f53807b690a5ab1e
sanket1729:
ACK f8945d05d82b90456fc68812f53807b690a5ab1e
Tree-SHA512: a3f8112d29cdb81d09492277958cad895bdcc4cb933d68b4d25c02cf0ca079922a0d903c3e48ec701bc51f15d8c66d05e9dc7ba56031c28d4a88bc7df1fbaa89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy emits:
warning: very complex type used. Consider factoring parts into
typedefinitionsThe type we return is more complex than needed because we do not use the
bip32::KeySourcealias but instead write the full tuple(byp32::Fingerprint, bip32::DerivationPath).To fix the clippy warning we have at least 3 options
bip32::KeySourceinstead of tuple(1) seems like an overkill
(2) means we loose lint coverage for the whole function
Elect to do (3), the best of 3 imperfect solutions.