integration_test: Enable edition 2018 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable edition 2018 in the manifest and remove usage of `extern crate`.
Cargo emits warning: warning: hidden lifetime parameters in types are deprecated As suggested, use the anonymous lifetime.
As we have edition 2018 we no longer need to import `bitcoin` explicitly.
apoelstra
approved these changes
May 3, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ion 2018
3188d06e6ecb8e84547fe72d9c998fe22aa467c5 Remove unneeded import (Tobin C. Harding)
abb2f558aef65791be63255d36beca682c3034dd Use the anonymous lifetime (Tobin C. Harding)
45a5d4900327287e2a02bf3b0d0c13979892fcc3 Enable edition 2018 (Tobin C. Harding)
Pull request description:
As we did for the main crate, enable edition 2018 in the `integration_test` crate.
ACKs for top commit:
apoelstra:
ACK 3188d06e6ecb8e84547fe72d9c998fe22aa467c5
sanket1729:
ACK 3188d06e6ecb8e84547fe72d9c998fe22aa467c5
Tree-SHA512: 8183cbc074a36175f1a7f723e89629577e13c646274730abc4bb9b5e16c2a250dad4dfb4059283ab7523d9586d9728f0b381afe991e9ec51c9ea641b5dc60480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did for the main crate, enable edition 2018 in the
integration_testcrate.