Remove extern crates #382
Merged
Remove extern crates #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have edition 2018 we no longer need to import crates in the examples, either using `extern` or otherwise. Remove crate imports, including `extern crate`.
Now we have edition 2018 we no longer need to use `extern crate` in the docs examples.
Now that we have edition 2018 we can re-expert `serde` using a `pub use` statement instead of `pub extern crate`.
apoelstra
approved these changes
May 3, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
b44acefa64ed834b0ba8b08c5748cc6b8d53af40 Re-export serde using without extern crate (Tobin C. Harding)
15817ddc9032dea29f3d834ffc0d450b09fa3cbc docs: Remove extern crate (Tobin C. Harding)
aacece4a7b30ed31a123e55fb87719ad2316589c examples: Remove crate imports (Tobin C. Harding)
Pull request description:
Now we have edition 2018 we can remove the usage of `extern crate`.
- Patch 1 does the `examples/`
- Patch 2 does the docs
- Patch 3 does the main crate
ACKs for top commit:
apoelstra:
ACK b44acefa64ed834b0ba8b08c5748cc6b8d53af40
sanket1729:
ACK b44acefa64ed834b0ba8b08c5748cc6b8d53af40
Tree-SHA512: f66280d1484aaac7607ee71537eef173d37545da39adf0e5de759bb5dee7d856aeaeb079bd312768360e21cca85945fadb42383353709082175f49961c06a6ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have edition 2018 we can remove the usage of
extern crate.examples/