Refactor the TranslatePk types #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to make the code more readable refactor the 4 `TranslatePk[X]` types by doing: - Improve docs - Shorten parameter names to assist formatting with no loss of clarity - Use `where` instead of inline trait bounds
Member
|
Thanks for doing this and taking a look at |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
a4bf096b9d39a27d00e0337f090021e02bc1fb98 Refactor the TranslatePk types (Tobin C. Harding)
Pull request description:
In an effort to make the code more readable refactor the 4 `TranslatePk[X]` types by doing:
- Improve docs
- Shorten parameter names to assist formatting with no loss of clarity
- Use `where` instead of inline trait bounds
ACKs for top commit:
sanket1729:
ACK a4bf096b9d39a27d00e0337f090021e02bc1fb98
Tree-SHA512: 2cbc5c660d4f9c353a4d2367a4fcf9aac65f65e5daedcf3337ed29209f69b326abeb068f07e19a65aee2f895e3a5deae6b8a27fd0fb4b4cb8fe388651699887b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the code more readable refactor the 4
TranslatePk[X]types by doing:whereinstead of inline trait bounds