Enforce that x-only keys cannot be used in non-tr descriptors #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK for the change, but I was wondering: why aren't you just returning Unless something recently changed in master, I'm looking at the docs for rc.2 and I don't see how something other than a |
sanket1729
force-pushed
the
x_only_fixup_04_2022
branch
from
9eefe94 to
f74fbe3
Compare
Reported by: @affilini
This commit can be re-arranged to check that this fails before the fix
sanket1729
force-pushed
the
x_only_fixup_04_2022
branch
from
f74fbe3 to
8212b9c
Compare
Member
Author
|
@afilini, fixed. Thanks for the suggestion |
afilini
approved these changes
Apr 14, 2022
apoelstra
approved these changes
Apr 19, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ot be used in non-tr descriptors 8212b9c8c1922a39425c0517d8c1ff8477b69f06 Add breaking test testing x-only keys in non-tr descriptors (sanket1729) 7ef4fdc19fa120a7a4b50d78484c8457db5fe9f2 Enforce that x-only keys cannot be used in non-tr descriptors (sanket1729) Pull request description: Reported by: @afilini . This was a copy-paste error on my side :( ACKs for top commit: afilini: ACK 8212b9c8c1922a39425c0517d8c1ff8477b69f06 apoelstra: ACK 8212b9c8c1922a39425c0517d8c1ff8477b69f06 Tree-SHA512: 22b71b72eb2ba5207d4581fa358c8146fb103cf0b2b80c6235d1cde8066acad6ed1aaab9cf997f11882981967fc8a869c4b35501f2e203ae1950079f73619439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by: @afilini .
This was a copy-paste error on my side :(