Skip to content

Use rust-bitcoin taproot max node count constant #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

Use rust-bitcoin taproot max node count constant #343

merged 1 commit into from
Apr 18, 2022

Conversation

@dunxen
Copy link
Contributor

@dunxen dunxen commented Apr 8, 2022

Fixes #334

sanket1729
sanket1729 approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b907cad

apoelstra
apoelstra approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b907cad

I think this is good to merge?

@sanket1729 sanket1729 merged commit a2d6fff into rust-bitcoin:master Apr 18, 2022
@dunxen dunxen deleted the 2022-04-taproot-max-node branch April 19, 2022 12:43
heap-coder added a commit to heap-coder/rust-miniscript that referenced this pull request Sep 27, 2025
@heap-coder
Merge rust-bitcoin/rust-miniscript#343: Use rust-bitcoin taproot max …
b20288c 
…node count constant

b907cadef5687bf77a98c7f381cc9949cecea630 Use rust-bitcoin taproot max node count constant (Duncan Dean)

Pull request description:

  Fixes #334

ACKs for top commit:
  sanket1729:
    utACK b907cadef5687bf77a98c7f381cc9949cecea630
  apoelstra:
    ACK b907cadef5687bf77a98c7f381cc9949cecea630

Tree-SHA512: 6b91917ebca1a1f971736fc52b580a0dbb749f033f2b23ece9e87a420e678b1edff54ffdc9258eebbf244ca091b9d52f536d531b75cd6250dd0dafe31cece3d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Constant TAPROOT_MAX_NODE_COUNT duplicates rust-bitcoin one

3 participants

@dunxen @apoelstra @sanket1729