Fix tr for each key bug #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dr-orlovsky |
dr-orlovsky
approved these changes
Mar 22, 2022
Contributor
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
tACK 92e504c
Tested with my wallet, now it works:
xpub:
tpubDC7mz8DJG7cy72MomPR2TmkfA6kjqYkEtYPHigBcycRaaPGD4fgmS8WWADEPNN685xVepi8nee1xGEYR33iNj9hy5HpqhtAKTT2uq4uq7jv:
- 877c9433
- "m/86'/1'/0'"
tpubDC7mz8DJG7cyYEWffExngTpWvjn6rZqaAkugaiHKVzsw9jA5fL7Ch8G2KSxGpraZZNYEKaH4uDExLbtE5ySBA49ZZfP6aXjvAHVyyxjEEeu:
- 877c9433
- "m/86'/1'/10'"
tpubDC7mz8DJG7cyb3BEFXtK1FbvoD3Y81RTjqUUvkaZDXbQExaaMAg1gNy1yLQeRYbL94eFfQ4WymxksrWJJYCLh7Fwrs1e5wG1TwAsKrruUS9:
- 877c9433
- "m/86'/1'/11'"
tpubDC7mz8DJG7cycqGg8AnwnvRT2Gwwgr9tf6Xv8ejs6Ec5gcg1PPnukYnwUADsb6EQPT3SdHg6zrC9WRwoPUan2PpaqtNRbUJxWZJkGmeh1HZ:
- 877c9433
- "m/86'/1'/12'"Previosly it was just two keys, not four)
Contributor
|
May I ask please to do RC2 after the fix merge? |
Member
Author
|
I think we want to do another RC after next RC for rust-bitcoin |
apoelstra
approved these changes
Mar 28, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
92e504c6b55f7b5b0aa4db14dd8e9800b2639135 Add breaking test case (sanket1729)
8c07952ecb36f5abe6d3974e06657c9c0f5dc9ba Fix tr for each key bug (sanket1729)
Pull request description:
You can re-order commits to see that this is fixed.
ACKs for top commit:
dr-orlovsky:
tACK 92e504c6b55f7b5b0aa4db14dd8e9800b2639135
apoelstra:
ACK 92e504c6b55f7b5b0aa4db14dd8e9800b2639135
Tree-SHA512: 14f9c045f24ad3147a2220e1a8d5cb3ae5416760993890675d5e1c46101113a991ba43effc11967776c0018f78816d3fb93c8e244e048305213a106c74a85701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can re-order commits to see that this is fixed.