Add timelock mix tests from miniscript alloy spec #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you rebase this? Github is confused and is still showing two commits from #257 in this. |
Member
Author
|
Rebased |
Member
Author
|
|
Member
|
Do these tests need to be ignored? On my system they run in less than a second. |
Member
Author
|
No, these run really fast. I don't think the ignored is needed. |
Fix bugs from alloy spec Possibly has some bugs in j: wrapper implementation. Will squash this commit later
apoelstra
approved these changes
Sep 13, 2021
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…iniscript alloy spec
003226ee34cd13048eda165404bddda644a736be Add all tests from alloy spec (sanket1729)
0a7e9b4390befa8ac1582574f8db460c0bb2cc11 Add malleable test vectors (sanket1729)
f98ecbc8bfed7a60a039547e5d3d0c2ac458ca19 Add timelock tests (sanket1729)
e0af5b7c9164e5fcb3634ad0a6def2e34f02244d Don't enforce strict cannonical wrappers (sanket1729)
Pull request description:
There found one bug in the current type system! The last commit disables the test while I work on fuzzer fix for rust-secp256k1.
ACKs for top commit:
apoelstra:
ACK 003226ee34cd13048eda165404bddda644a736be
Tree-SHA512: 399c8d2cc6c872d7c4a908809c492c495c04cbf59e757602f913fc11fb8d69ecb567da63a824faacfcf8dd0b116748c74ff4858ccb4e4d7c4444ce7bf6049481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There found one bug in the current type system! The last commit disables the test while I work on fuzzer fix for rust-secp256k1.