This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Add sha256t_hash_newtype macro to create tagged hash newtypes #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
reviewed
Oct 7, 2020
stevenroose
force-pushed
the
tagged-newtype
branch
4 times, most recently
from
8f5b002 to
c46d75f
Compare
dr-orlovsky
approved these changes
Oct 7, 2020
stevenroose
force-pushed
the
tagged-newtype
branch
from
c46d75f to
1685193
Compare
Contributor
|
confirm my ACK |
Contributor
|
Just understood that this macro uses |
Collaborator
Author
|
Why do you use bech32? Hmm yeah well the reason I had these in rust-bitcoin in a taproot module was partly to make sure this wouldn't grow larger than just taproot usage. But still I think as long as there is no Bitcoin usage of tagged hashes that serializes differently, I think it's fine here. It's really not super hard to specify an alternative macro in your project to create bech32 tagged hash newtypes, right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.