This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Hack around the broken dyn-clone dependency #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of `dyn-clone` v1.0.8 breaks our build. We can pin the dependency to the version before that works. Requires some toml magic akin to what we do with `actual-serde` in `rust-bitcoin`.
tcharding
force-pushed
the
07-21-dyn-clone
branch
from
25542ce to
67aa7ac
Compare
|
Cool, I think this minimally irritates both me and @JeremyRubin. Let's do it. |
|
Looks fine to me! Thanks
…On Thu, Jul 21, 2022, 5:37 AM Andrew Poelstra ***@***.***> wrote:
Cool, I think this minimally irritates both me and @JeremyRubin
<https://github.com/JeremyRubin>. Let's do it.
—
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGYN675C5VSV6IXHZTWHRLVVFABZANCNFSM54F2W7ZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
apoelstra
approved these changes
Aug 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
dyn-clonev1.0.8 breaks our build (usesArc::as_ptrwhich only became available in Rust 1.45).We can pin the dependency to a version before that works. Requires some toml magic akin to what we do with
actual-serdeinrust-bitcoin.