Fix no_std #107
Fix no_std #107
Conversation
Use `core::convert` instead of `std::convert`
|
Why isn't CI catching this? I will PR to switch to github actions, and redo our scripts and make them work. Unfortunately the build is currently failing in a few ways so it may be a bit of work. |
Because we only use this macro in tests, where |
|
small note, alloc only and no-std are distinctly different |
|
Converting this to draft for now. I'm starting to add other stuff to get rust-bitcoin working on real MCUs. |
|
can you rebase on current master? In #109 we did a fair bit of code cleanup including some nostd fixes. |
|
I see bare-io is now called core2 and from the badge, it looks it requires 1.47+ |
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
What is the current status on this taking into account all other work on no_std with bringing core2 support?
| #[macro_use] mod util; | ||
| #[macro_use] pub mod serde_macros; | ||
| #[cfg(any(test, feature = "std"))] mod std_impls; | ||
| pub mod impls; |
There was a problem hiding this comment.
Why we need this to be pub? It does not define any types to export
|
cc @justinmoon I think we've decided to go with core2 rather than bare-io, see recently-merged #128 and #130. Should we close this PR or would you like us to revisit it? |
|
bare-io was renamed core2. core2 is just the new version (though still beta, AFAIU). I think this can be closed.
… On Jun 17, 2021, at 17:57, Andrew Poelstra ***@***.***> wrote:
cc @justinmoon I think we've decided to go with core2 rather than bare-io, see recently-merged #107 and #130.
Should we close this PR or would you like us to revisit it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Closing. Feel free to reopen @justinmoon if you'd like us to revisit this. |
6 participants
Use
core::convertinstead ofstd::convert