-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Regression analysisCI failure: https://github.com/runtimeverification/pyk/actions/runs/6091261943/job/16527607156?pr=634 Caused by: runtimeverification/haskell-backend#3637 Generate bug-report with
Running
results in a
and due to the regression, additionally:
|
bdf404c
to
8ca7e0f
Compare
Fix for change introduced by #3637, wherein branching could contain bottom states which were not being pruned. (see runtimeverification/pyk#634 (comment))
bd505ec
to
9bf3227
Compare
@@ -93,6 +93,7 @@ def cterm_execute( | |||
next_state = CTerm.from_kast(self.kprint.kore_to_kast(er.state.kore)) | |||
_next_states = er.next_states if er.next_states is not None else [] | |||
next_states = [CTerm.from_kast(self.kprint.kore_to_kast(ns.kore)) for ns in _next_states] | |||
next_states = [cterm for cterm in next_states if not cterm.is_bottom] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for a hotfix. @PetarMax, please open an issue for dropping it (or perhaps replacing it for an assertion) once runtimeverification/haskell-backend#3650 makes it's way through the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]> Co-authored-by: Petar Maksimovic <[email protected]>
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]> Co-authored-by: Petar Maksimovic <[email protected]>
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]> Co-authored-by: Petar Maksimovic <[email protected]>
Co-authored-by: devops <[email protected]> Co-authored-by: Tamás Tóth <[email protected]> Co-authored-by: Petar Maksimovic <[email protected]>
No description provided.