This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Automating implication-every-block reasoning
#580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
approved these changes
Aug 7, 2023
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…yk#580) This PR removes the need for the `implication-every-block` parameter in APR-related provers. The reasoning is as follows: - if the `target` node is a `terminal` node, then subsumption into target should be checked only for `terminal` nodes (equivalent to previously setting `implication-every-block` to `false`) - otherwise (and this is possible, for example, for internal functions), subsumption into target is checked on every block ((equivalent to previously setting `implication-every-block` to `true`). I am assuming that this change requires changes to KEVM so that the `implication-every-block` parameter is removed. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…yk#580) This PR removes the need for the `implication-every-block` parameter in APR-related provers. The reasoning is as follows: - if the `target` node is a `terminal` node, then subsumption into target should be checked only for `terminal` nodes (equivalent to previously setting `implication-every-block` to `false`) - otherwise (and this is possible, for example, for internal functions), subsumption into target is checked on every block ((equivalent to previously setting `implication-every-block` to `true`). I am assuming that this change requires changes to KEVM so that the `implication-every-block` parameter is removed. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…yk#580) This PR removes the need for the `implication-every-block` parameter in APR-related provers. The reasoning is as follows: - if the `target` node is a `terminal` node, then subsumption into target should be checked only for `terminal` nodes (equivalent to previously setting `implication-every-block` to `false`) - otherwise (and this is possible, for example, for internal functions), subsumption into target is checked on every block ((equivalent to previously setting `implication-every-block` to `true`). I am assuming that this change requires changes to KEVM so that the `implication-every-block` parameter is removed. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…yk#580) This PR removes the need for the `implication-every-block` parameter in APR-related provers. The reasoning is as follows: - if the `target` node is a `terminal` node, then subsumption into target should be checked only for `terminal` nodes (equivalent to previously setting `implication-every-block` to `false`) - otherwise (and this is possible, for example, for internal functions), subsumption into target is checked on every block ((equivalent to previously setting `implication-every-block` to `true`). I am assuming that this change requires changes to KEVM so that the `implication-every-block` parameter is removed. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for the
implication-every-blockparameter in APR-related provers. The reasoning is as follows:targetnode is aterminalnode, then subsumption into target should be checked only forterminalnodes (equivalent to previously settingimplication-every-blocktofalse)implication-every-blocktotrue).I am assuming that this change requires changes to KEVM so that the
implication-every-blockparameter is removed.