Add key bindings to the kcfg-viewer #460

iFrostizz · 2023-05-25T12:21:34Z

Closes: #458

TODO

edit 05.25:

This is how it looks like

edit 06.06:

edit 13.06:

ehildenb · 2023-05-25T14:28:54Z

Please post a gif with the changes.

Also, instead of changing the boarder on the left of a selected node, perhaps we change the background color, which makes it easier to see without changing the look of the graph.

…fg-key merge

iFrostizz · 2023-06-05T08:15:18Z

Note: this call is especially quite slow, which makes the app launch proportionally longer as there is more node.

pyk/src/pyk/kcfg/tui.py

Line 286 in d07d63c

for lseg_id, node_lines in kcfg_show.pretty_segments(

merge master

…fg-key

Going in a more step-by-step fashion compared to #460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

Anticipating for runtimeverification/pyk#460 This will allow us to use `VerticalScroll` widgets to scroll programatically. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]> Co-authored-by: rv-jenkins <[email protected]> Co-authored-by: Sam Balco <[email protected]>

Going in a more step-by-step fashion compared to runtimeverification/pyk#460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

Anticipating for runtimeverification/pyk#460 This will allow us to use `VerticalScroll` widgets to scroll programatically. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]> Co-authored-by: rv-jenkins <[email protected]> Co-authored-by: Sam Balco <[email protected]>

Going in a more step-by-step fashion compared to runtimeverification/pyk#460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

Anticipating for runtimeverification/pyk#460 This will allow us to use `VerticalScroll` widgets to scroll programatically. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]> Co-authored-by: rv-jenkins <[email protected]> Co-authored-by: Sam Balco <[email protected]>

Going in a more step-by-step fashion compared to runtimeverification/pyk#460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

Anticipating for runtimeverification/pyk#460 This will allow us to use `VerticalScroll` widgets to scroll programatically. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]> Co-authored-by: rv-jenkins <[email protected]> Co-authored-by: Sam Balco <[email protected]>

Going in a more step-by-step fashion compared to runtimeverification/pyk#460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

Anticipating for runtimeverification/pyk#460 This will allow us to use `VerticalScroll` widgets to scroll programatically. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]> Co-authored-by: rv-jenkins <[email protected]> Co-authored-by: Sam Balco <[email protected]>

Going in a more step-by-step fashion compared to runtimeverification/pyk#460 Rolling out our own key bindings was messing up with the defaults of textual and adding a lot of unecessary boilerpalte. This PR also closes it. - Dedicated classes for each widget in the `NodeView` (Term, Constraint, Info, Custom) - Relevant ones all inherits from `ScrollableContainer` and can be focused. Adds native key bindings and can be selected using `Tab` or `Tab+Shift` to loop the other way around - using an absolute path for the css file so that the class `APRProofViewer` inherits `KCFGViewer`'s css. `@import` is not something that works with textual, but as we may want in the future to add stuff only for the `APRProofViewer` css. --------- Co-authored-by: François Guyot <[email protected]> Co-authored-by: devops <[email protected]>

François Guyot and others added 6 commits May 24, 2023 14:23

add custom key bindings

20ed19d

add start / end

d8d7eb1

highlight current node

f2ae17b

only consider cut nodes

3a47f84

Merge 3a47f84 into ce5421a

1c392cd

Set Version: 0.1.306

22e9799

iFrostizz self-assigned this May 25, 2023

François Guyot added 2 commits May 25, 2023 13:02

remove highlight on click away

372aa8d

order nodes by branching

4534ad4

iFrostizz marked this pull request as draft May 29, 2023 06:29

bump textual, update to breaking changes

e64226c

iFrostizz mentioned this pull request Jun 5, 2023

Bump textual to latest #480

Merged

François Guyot and others added 15 commits June 5, 2023 07:53

Merge branch 'textual-bump' into kcfg-key

b01ca34

Merge b01ca34 into 174ce21

074c40f

Set Version: 0.1.318

7f0fbb4

Merge 7f0fbb4 into 174ce21

e70d190

Set Version: 0.1.319

371e7b3

conflicts

6fc7470

Merge branch 'kcfg-key' of github.com:runtimeverification/pyk into kc…

0e2233d

…fg-key merge

Merge 0e2233d into 174ce21

0696cc4

Set Version: 0.1.318

ca23ed6

Merge ca23ed6 into 174ce21

85ab501

Set Version: 0.1.319

d388ca1

adapt to textual ver

8f631ce

Merge branch 'kcfg-key' of github.com:runtimeverification/pyk into kc…

20ff149

…fg-key merge

Merge 20ff149 into fefe75d

379489e

Set Version: 0.1.320

d07d63c

center view

a3cc222

François Guyot and others added 17 commits June 21, 2023 12:21

Merge branch 'master' into kcfg-key

b3be6f8

merge master

Merge b3be6f8 into e0cb467

cecd417

Set Version: 0.1.345

6907cd9

remove buffer, use default scrollable

22a4e4a

Merge 22a4e4a into bdba8da

08197ba

Set Version: 0.1.346

ed7a748

update to new node printing

ed0f4b1

Merge branch 'kcfg-key' of github.com:runtimeverification/pyk into kc…

d1ee2de

…fg-key

use ScrollableContainer

154c91f

Merge 154c91f into 94c3f69

67a3bce

Set Version: 0.1.347

55c3cab

allow widget focus

c9153d1

Merge branch 'kcfg-key' of github.com:runtimeverification/pyk into kc…

964023c

…fg-key

simplify tui

8abc1f5

compose Static elements

c6a7a20

update content

ec79399

use reactive attributes

6899f62

iFrostizz mentioned this pull request Aug 4, 2023

Refactor of the KCFGViewer #578

Merged

iFrostizz closed this Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add key bindings to the kcfg-viewer #460

Add key bindings to the kcfg-viewer #460

Uh oh!

iFrostizz commented May 25, 2023 •

edited

Loading

Uh oh!

ehildenb commented May 25, 2023

Uh oh!

iFrostizz commented Jun 5, 2023

Uh oh!

Uh oh!

Add key bindings to the kcfg-viewer #460

Add key bindings to the kcfg-viewer #460

Uh oh!

Conversation

iFrostizz commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

ehildenb commented May 25, 2023

Uh oh!

iFrostizz commented Jun 5, 2023

Uh oh!

Uh oh!

iFrostizz commented May 25, 2023 •

edited

Loading