Skip to content

report SMT timeout errors #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 9, 2024
Merged

report SMT timeout errors #490

merged 18 commits into from
Apr 9, 2024

Conversation

ovatman
Copy link
Contributor

@ovatman ovatman commented Mar 27, 2024

This PR resolves #21 in collaboration with the PR runtimeverification/pyk#1025. SMT timeouts are propagated from pyk inside CTermSMTError exception which are then catched and a proper error message is reported including current timeout value.

@ovatman ovatman self-assigned this Mar 27, 2024
@ovatman ovatman requested a review from palinatolmach March 27, 2024 13:55
@ovatman ovatman added the enhancement New feature or request label Mar 27, 2024
@ovatman
Copy link
Contributor Author

ovatman commented Mar 27, 2024

Currently this PR does not pass quality checks because of the dependent PR in pyk. Consider when reviewing.

@ehildenb ehildenb marked this pull request as draft March 27, 2024 18:27
@palinatolmach palinatolmach requested a review from anvacaru March 28, 2024 06:18
@ovatman ovatman marked this pull request as ready for review April 4, 2024 10:41
@ovatman ovatman marked this pull request as draft April 4, 2024 12:58
@ovatman ovatman marked this pull request as ready for review April 4, 2024 15:49
@ovatman ovatman marked this pull request as draft April 4, 2024 18:51
Copy link
Contributor

@palinatolmach palinatolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to automerge!

@palinatolmach palinatolmach marked this pull request as ready for review April 5, 2024 08:36
@palinatolmach palinatolmach merged commit eb39d93 into master Apr 9, 2024
@palinatolmach palinatolmach deleted the tolga/smt-timeout-message branch April 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report SMT solver timeout in CLI output
5 participants