Unification returns an 'Or' #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traiansf
approved these changes
Dec 20, 2018
virgil-serbanuta
force-pushed
the
or-for-unification
branch
from
c9c0262 to
3ca91c1
Compare
jberthold
added a commit
that referenced
this pull request
Apr 10, 2024
Fixes #391 Fixes #390 - Comments inserted into transcript to explain what things are - `ensures` clauses are now checked with the SMT solver (changes integration test expectations) - a test using `==K` (currently fails on `booster-dev`, `kore-rpc` appears to use internal `==K` logic instead of `z3` to solve it) - supplying SMT options to `kore-rpc` via the `SMTOption` type in the new code - separate kill switch `--no-booster-smt` to disable the SMT solver only in booster code but keep the one in `kore-rpc` - ~SMT support for equation evaluation~ reverted --------- Co-authored-by: github-actions <[email protected]>
jberthold
added a commit
that referenced
this pull request
Apr 10, 2024
Fixes #391 Fixes #390 - Comments inserted into transcript to explain what things are - `ensures` clauses are now checked with the SMT solver (changes integration test expectations) - a test using `==K` (currently fails on `booster-dev`, `kore-rpc` appears to use internal `==K` logic instead of `z3` to solve it) - supplying SMT options to `kore-rpc` via the `SMTOption` type in the new code - separate kill switch `--no-booster-smt` to disable the SMT solver only in booster code but keep the one in `kore-rpc` - ~SMT support for equation evaluation~ reverted --------- Co-authored-by: github-actions <[email protected]>
jberthold
added a commit
that referenced
this pull request
Apr 10, 2024
Fixes #391 Fixes #390 - Comments inserted into transcript to explain what things are - `ensures` clauses are now checked with the SMT solver (changes integration test expectations) - a test using `==K` (currently fails on `booster-dev`, `kore-rpc` appears to use internal `==K` logic instead of `z3` to solve it) - supplying SMT options to `kore-rpc` via the `SMTOption` type in the new code - separate kill switch `--no-booster-smt` to disable the SMT solver only in booster code but keep the one in `kore-rpc` - ~SMT support for equation evaluation~ reverted --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test using "assertTermEqualsMulti" in Equals.hs highlights a bug in the equals simplification.
Reviewer checklist
stack test --coveragestack haddockstylish-haskell