Fix ISO 8601 timestamp formatting #72
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotoken
reviewed
Sep 13, 2021
| @@ -529,7 +529,7 @@ def set_dir_list(req, res) | |||
| dname = name | |||
| end | |||
| s = +"<TR><TD class=\"name\"><A HREF=\"#{HTTPUtils::escape(name)}#{query if name.end_with?('/')}\">#{HTMLUtils::escape(dname)}</A></TD>" | |||
| s << "<TD class=\"mtime\">" << (time ? time.strftime("%Y/%m/%d %H:%M") : "") << "</TD>" | |||
| s << "<TD class=\"mtime\">" << (time ? time.strftime("%Y-%m-%d %H:%M") : "") << "</TD>" | |||
There was a problem hiding this comment.
I think there are two difficulties
- Maybe there already exist log analyzers uses the current format even if
%Y-%m-%dis better to read for people in some locales. - ISO 8601 needs putting
Tbetween%Y-%m-%dand%H:%M, i.e.,%Y-%m-%dT%H:%M. And it's not clear which is better,"%Y/%m/%d %H:%Mor%Y-%m-%dT%H:%M.
|
By my check, this is not ISO 8601 formatting. Do you mind explaining the problem you are trying to solve? Or is it purely cosmetic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.