Use new name for cat19 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cannot be merged until JRuby has released a version that supports it, and should not be released until we have decided how to transition away from older JRuby versions that do not have this name. See ruby#83
Contributor
Author
|
I decided to support both old and new using a MethodHandle. Performance should not be impacted since it's static final, but it will work on all old versions of JRuby until we decide to remove this logic. |
headius
added a commit
to headius/stringio
that referenced
this pull request
Mar 13, 2024
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 13, 2024
Another one used by StringIO. See ruby/stringio#84 and ruby/stringio#88.
headius
added a commit
to jruby/jruby
that referenced
this pull request
Mar 13, 2024
See ruby/stringio#84 and ruby/stringio#88 for info on this transition.
headius
added a commit
that referenced
this pull request
Mar 13, 2024
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 13, 2024
Additional two names used by StringIO. See ruby/stringio#84 and ruby/stringio#88.
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 13, 2024
Additional two names used by StringIO. See ruby/stringio#84 and ruby/stringio#88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be merged until JRuby has released a version that supports it, and should not be released until we have decided how to transition away from older JRuby versions that do not have this name.
See #83