Skip to content

Update the coderange after overwrite #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update the coderange after overwrite #79

merged 1 commit into from
Jan 16, 2024

Conversation

@nobu
Copy link
Member

@nobu nobu commented Jan 16, 2024

@nobu nobu merged commit 8230552 into ruby:master Jan 16, 2024
@nobu nobu deleted the coderange_after_overwrite branch January 16, 2024 15:06
@kou kou mentioned this pull request Jan 17, 2024
Merged
kou pushed a commit that referenced this pull request Jan 18, 2024
@tompng
Fix ascii_only? flag in strio_write (#77)
b31a538 
Followup of #79

`rb_str_resize()` was changed by ruby/ruby@b0b9f72  .

```c
rb_str_resize(string, shorter) // clear ENC_CODERANGE in some case
rb_str_resize(string, longer) // does not clear ENC_CODERANGE anymore
```

```c
// rb_str_resize in string.c
if (slen > len && ENC_CODERANGE(str) != ENC_CODERANGE_7BIT) {
  ENC_CODERANGE_CLEAR(str);
}
```

I think this change is based on an assumption that appending null bytes
will not change flag `ascii_only?`.

`strio_extend()` will make the string longer if needed, and update the
flags correctly for appending null bytes.
Before `memmove()`, we need to `rb_str_modify()` because updated flags are not
updated for `memmove()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nobu