Make sure shared buffer is copied on mutation #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure shared buffers are made independent on mutation. Otherwise we could end up mutating unrelated string buffers. Co-Authored-By: Alan Wu <[email protected]>
kou
reviewed
Feb 19, 2025
kou
reviewed
Feb 19, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
kou
reviewed
Feb 20, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
Member
|
Thanks. |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 20, 2025
(ruby/stringio#117) We need to ensure shared buffers are made independent on mutation. Otherwise we could end up mutating unrelated string buffers. --------- ruby/stringio@5101cfb030 Co-authored-by: Aaron Patterson <[email protected]> Co-authored-by: Alan Wu <[email protected]> Co-authored-by: Aaron Patterson <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>
mrzasa
pushed a commit
to mrzasa/ruby
that referenced
this pull request
Feb 21, 2025
(ruby/stringio#117) We need to ensure shared buffers are made independent on mutation. Otherwise we could end up mutating unrelated string buffers. --------- ruby/stringio@5101cfb030 Co-authored-by: Aaron Patterson <[email protected]> Co-authored-by: Alan Wu <[email protected]> Co-authored-by: Aaron Patterson <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure shared buffers are made independent on mutation. Otherwise we could end up mutating unrelated string buffers.