Skip to content

Fixed the regression of #388 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fixed the regression of #388 #389

merged 1 commit into from
Jul 8, 2021

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Jul 8, 2021

Fixed #388

tbrisker
tbrisker approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hsbt, lgtm !

@hsbt hsbt merged commit 3a95f4c into master Jul 8, 2021
@hsbt hsbt deleted the fix-388 branch July 8, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tbrisker tbrisker tbrisker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rake test fails to run with uninitialized constant FileList (NameError)

3 participants

@hsbt @tbrisker