-
Notifications
You must be signed in to change notification settings - Fork 182
ssl: add post-quantum cryptography (PQC) tests #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MSP-Greg Do you have any ideas why the post-quantum cryptography (PQC) tests are failing on Windows OpenSSL 3.5 cases? |
This is a known issue with TLS 1.3 and has nothing to do with PQC. This actually happens on other platforms, too. The TCP connection is closed by the client before the server finishes |
rhenium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the new methods closer to other relevant test cases.
5bf0645 to
7181539
Compare
All right. Thanks for the info. I added the |
All right, I moved the PQC tests to the other relevant test cases. The |
junaruga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review! I rebased the PR, fixing most things mentioned by you. Please keep in mind that there is a new change exposing the ca_exts and ee_exts in the test/openssl/utils.rb.
Now what do you think?
The key files were created by the following commands.
```
$ ${HOME}/.local/openssl-3.6.0-dev-fips-debug-8253b58d60/bin/openssl genpkey \
-algorithm mldsa65 \
-out mldsa65-1.pem
$ ${HOME}/.local/openssl-3.6.0-dev-fips-debug-8253b58d60/bin/openssl genpkey \
-algorithm mldsa65 \
-out mldsa65-2.pem
```
PQC algorithms, ML-KEM (FIPS 203) and ML-DSA (FIPS 204) used in the PQC tests
are supported on OpenSSL 3.5 or later.
https://openssl-library.org/post/2025-04-08-openssl-35-final-release/
I investigated the above thing with the help of my colleagues working for OpenSSL. The following OpenSSL 3.5 release note helped me to check if the PQC is really supported in OpenSSL 3.5 or later. https://openssl-library.org/post/2025-04-08-openssl-35-final-release/
The following commits are adding the entries in the
I updated the comment above the line I think I fixed everything mentioned by you in the review. Now what do you think? |
rhenium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks for your review! By the way, for someone wondering why the PQC algorithm SLH-DSA test doesn't exist in this PR. The reason is below. It's not good time to add the SLH-DSA test for now.
|
This PR is related to the #894. And this PR is the last PR of the issue ticket. This PR is working in progress. Because I have the following 2 things to fix or investigate.
test_pqcandtest_pqc_groupfailing on Windows OpenSSL 3.5 cases. The CI log is here. But as I could find the failures of the Windows cases, I could prove the usefulness of these PQC tests. 😃What do you think?
Note the key files were created by the following commands.