Gemfile: Avoid installing rdoc in TruffleRuby. #704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
force-pushed
the
wip/gemfile-no-rdoc-in-ci
branch
from
faa8b2b to
e2b85c2
Compare
junaruga
commented
Nov 25, 2023
Avoid installing rdoc in TruffleRuby as a workaround of the truffleruby-head version 24.0.0-dev issue.
junaruga
force-pushed
the
wip/gemfile-no-rdoc-in-ci
branch
from
e2b85c2 to
b58285e
Compare
junaruga
changed the title
Member
Author
|
As the #699 was fixed, we don't need this PR any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround to avoid the issue #699,
by using a GitHub Actions environment variable. The links is here. I feel using the environment variableI think that theCIis better thanGITHUB_ACTIONS, because I think we don't want to write GitHub Actions specific logic in our code.unless RUBY_ENGINE == "truffleruby"is better, because user can avoid this issue on TrufeeRuby on their local too.Avoid installing rdoc in CI as a workaround of the truffleruby-head version 24.0.0-dev issue.