Skip to content

Warning: "OPENSSL_FIPS" is not defined, evaluates to 0 [-Wundef] #620

@junaruga

Description

@junaruga

This issue was reported at the c5b2bc1 . Sorry it's my bad.

I was able to reproduce it on my local on Fedora 37.

Install OpenSSL 1.1.1t where that is less than OpenSSL 3, and the OPENSSL_FIPS macro is not defined.

$ git remote -v
origin	https://github.com/openssl/openssl.git (fetch)
origin	https://github.com/openssl/openssl.git (push)

$ git checkout OpenSSL_1_1_1t

$ ./Configure \
  --prefix=$HOME/.local/openssl-1.1.1t-debug \
  --libdir=lib \
  shared linux-x86_64 \
  -O0 -g3 -ggdb3 -gdwarf-5

$ make -j$(nproc)

$ LD_LIBRARY_PATH=$HOME/.local/openssl-1.1.1t-debug/lib/ \
  $HOME/.local/openssl-1.1.1t-debug/bin/openssl version -a
OpenSSL 1.1.1t  7 Feb 2023
built on: Tue May 16 19:40:34 2023 UTC
platform: linux-x86_64
options:  bn(64,64) rc4(16x,int) des(int) idea(int) blowfish(ptr)-
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -O0 -g3 -ggdb3 -gdwarf-5 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_CPUID_OBJ -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DKECCAK1600_ASM -DRC4_ASM -DMD5_ASM -DAESNI_ASM -DVPAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DX25519_ASM -DPOLY1305_ASM -DNDEBUG
OPENSSLDIR: "/home/jaruga/.local/openssl-1.1.1t-debug/ssl"
ENGINESDIR: "/home/jaruga/.local/openssl-1.1.1t-debug/lib/engines-1.1"
Seeding source: os-specific
$ bundle install --standalone
  
$ bundle exec rake compile -- \
  --with-openssl-dir=$HOME/.local/openssl-1.1.1t-debug \
  --with-cflags="-Wundef"
mkdir -p tmp/x86_64-linux/openssl/3.2.1
cd tmp/x86_64-linux/openssl/3.2.1
/usr/local/ruby-3.2.1/bin/ruby -I. -r.rake-compiler-siteconf.rb ../../../../ext/openssl/extconf.rb -- --with-openssl-dir=/home/jaruga/.local/openssl-1.1.1t-debug --with-cflags=-Wundef
...
gcc -I. -I/usr/local/ruby-3.2.1/include/ruby-3.2.0/x86_64-linux -I/usr/local/ruby-3.2.1/include/ruby-3.2.0/ruby/backward -I/usr/local/ruby-3.2.1/include/ruby-3.2.0 -I../../../../ext/openssl -DRUBY_EXTCONF_H=\"extconf.h\" -I/home/jaruga/.local/openssl-1.1.1t-debug/include    -fPIC -Wundef  -o ossl.o -c ../../../../ext/openssl/ossl.c
../../../../ext/openssl/ossl.c: In function ‘ossl_fips_mode_get’:
../../../../ext/openssl/ossl.c:425:7: warning: "OPENSSL_FIPS" is not defined, evaluates to 0 [-Wundef]
  425 | #elif OPENSSL_FIPS
      |       ^~~~~~~~~~~~
../../../../ext/openssl/ossl.c: In function ‘ossl_fips_mode_set’:
../../../../ext/openssl/ossl.c:460:7: warning: "OPENSSL_FIPS" is not defined, evaluates to 0 [-Wundef]
  460 | #elif OPENSSL_FIPS
      |       ^~~~~~~~~~~~
../../../../ext/openssl/ossl.c: In function ‘Init_openssl’:
../../../../ext/openssl/ossl.c:1218:7: warning: "OPENSSL_FIPS" is not defined, evaluates to 0 [-Wundef]
 1218 | #elif OPENSSL_FIPS
      |       ^~~~~~~~~~~~
...
cp tmp/x86_64-linux/openssl/3.2.1/openssl.so tmp/x86_64-linux/stage/lib/openssl.so

$ echo $?
0

I was not able to reproduce this issue on the CI. Perhaps the warnings are not printed when the mkmf V equals 0?

Here is the result on my local.

$ grep '^V =' /usr/local/ruby-3.2.1/lib/ruby/3.2.0/mkmf.rb 
V = #{CONFIG['MKMF_VERBOSE']}

$ grep -r MKMF_VERBOSE /usr/local/ruby-3.2.1/lib/ruby/3.2.0/x86_64-linux/rbconfig.rb 
  CONFIG["MKMF_VERBOSE"] = "1"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions