Skip to content

JITSupport use breaks tests under non-CRuby #2

@headius

Description

@headius

In 590e09b @k0kubun added logic to clear JIT logs during the popen2 test using JITSupport.

This breaks the test on implementations that do not have the same JIT flags and RubyVM support as CRuby.

If this logic is still necessary for the test to run on CRuby with JIT enabled, it should be masked to only run on CRuby. If it is no longer needed it should be reverted.

The rest of the jit_support.rb file does not seem to be used and was only ported over because it's used by the full test suite in CRuby (ac2e7bd by @hsbt).

I have some changes coming to let the open3 tests run on JRuby and include our Windows support files (JRuby only launches subprocesses through Java APIs on Windows, so different logic is required) and can also include this fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions