parser.c: optimize json_string_unescape #894
Open
+78
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes
json_string_unescape.Two commits:
\. While scanning, copy the current chunk to the output.If this PR is accepted, I will follow up with an SSE2 implementation.
Benchmarks
Run on a Macbook Air M1.
twitterescaped.json is from simdjson-data.
I should note that the fast path for unescaping a single character accounts for about 1% of the speed increase in
activitypub.json. It's pretty minor.