Skip to content

Explicitly define behavior of empty tls_options #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly define behavior of empty tls_options #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/integration/test_bind.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,25 @@ def test_bind_tls_with_valid_hostname_default_opts_passes
@ldap.get_operation_result.inspect
end

def test_bind_tls_with_valid_hostname_no_tls_options_passes
@ldap.host = 'localhost'
@ldap.encryption(
method: :start_tls,
)
assert @ldap.bind(BIND_CREDS),
@ldap.get_operation_result.inspect
end

def test_bind_tls_with_valid_hostname_empty_tls_options_passes
@ldap.host = 'localhost'
@ldap.encryption(
method: :start_tls,
tls_options: {},
)
assert @ldap.bind(BIND_CREDS),
@ldap.get_operation_result.inspect
end

def test_bind_tls_with_valid_hostname_just_verify_peer_ca_passes
@ldap.host = 'localhost'
@ldap.encryption(
Expand Down