Skip to content

Conversation

@mtodd
Copy link
Member

@mtodd mtodd commented Oct 10, 2014

While we move away from rspec and towards minitest, now seems like a good time to start running both to make sure builds don't break.

cc @jch @schaary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to drop official support for rbx for the 1.0 release as well, unless there's someone who's explicitly interested in supporting it. I don't think I can give it justice. Out of scope for this PR though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was feeling the same while testing this out. I think we can keep the builds, but put them under allow_failures so we can keep an eye on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to allow_failures. Be good to add ruby-head in there as well to foresee future incompatibilities

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also gonna punt on moving rbx to allowed failures/unofficial support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And by "unofficial support" I mean "not officially supported".

@jch
Copy link
Member

jch commented Oct 10, 2014

👍

mtodd added a commit that referenced this pull request Oct 11, 2014
@mtodd mtodd merged commit 0dd8f56 into master Oct 11, 2014
@mtodd mtodd deleted the ci-specs-and-tests branch October 11, 2014 04:33
@mtodd mtodd mentioned this pull request Oct 11, 2014
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants