Fix ScheduledTask sometimes not accepting an interval of 0 #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScheduledTask measured Time.now in 2 places with some computation in between and it sometimes arrived at an inconsistent result
|
Many of our tests are ugly, but sometimes that the only way to truly test this library. I'd be afraid of any concurrency library that used too many test doubles. If your spec revealed the problem and verified the solution it's good for me! |
jdantonio
added a commit
that referenced
this pull request
Feb 23, 2015
Fix ScheduledTask sometimes not accepting an interval of 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScheduledTask measured
Time.nowin 2 places with some computation inbetween and it sometimes arrived at an inconsistent result.
Sorry for the ugly spec - this is basically the way I reproduced it and I didn't want to bind too much to the implementation by stubbing out
TimerSet.calculate_schedule_timewith a sleep.Also - it only happened on jruby for me - maybe the clock is more accurate?