Skip to content

Avoid error when member is present on ancestor class #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Avoid error when member is present on ancestor class #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc930ab
Avoid error when member is present on ancestor class
francesmcmullin Oct 16, 2024
3a775c4
Improve ancestor classes spec
francesmcmullin Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def ns_initialize(*values)
end
end
members.each_with_index do |member, index|
clazz.send :remove_method, member if clazz.instance_methods.include? member
clazz.send :remove_method, member if clazz.instance_methods(false).include? member
clazz.send(:define_method, member) do
@values[index]
end
Expand Down
14 changes: 14 additions & 0 deletions spec/concurrent/struct_shared.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@
expect(clazz.ancestors).to include described_class
end

it 'ignores methods on ancestor classes' do
ancestor = described_class.ancestors.last
ancestor.class_eval { def foo(bar); end }

clazz = described_class.new(:foo)
struct = clazz.new

expect(struct).to respond_to :foo
method = struct.method(:foo)
expect(method.arity).to eq 0

ancestor.send :remove_method, :foo
end

it 'raises an exception when given an invalid class name' do
expect{ described_class.new('lowercase') }.to raise_error(NameError)
expect{ described_class.new('_') }.to raise_error(NameError)
Expand Down