Skip to content

Conversation

@gadenbuie
Copy link
Member

  • Add input_task_button, an actionButton with busy state
  • Add input_task_button to pkgdown, remove cruft
  • Remove more cruft
  • Refactor task button
  • Automatic reset of task button after reactive flush
  • Fix devtools::load_all("shiny")
  • Add input_task_button() item to NEWS
  • Code review feedback
  • Apply suggestions from code review
  • More code review feedback
  • Move shiny::bind_task_to_button to bslib::bind_task_button generic
  • Add example for bind_task_button
  • Add future to Suggests, only because it's used in a new example
  • Put task button's unnamed ... inside of
  • Fix comment
  • Use correct JSON member name
  • Code review feedback
  • Use @examplesIf interactive()
  • Make CI pass, hopefully
  • devtools::document() (GitHub Actions)
  • Don't error on repeated load_all
  • Add bind_task_button to index
  • Add note to docs
  • Fix example for R <4.1
  • fix(layout_columns): Don't break grid-column on md-down (fix(layout_columns): Don't break grid-column on md-down #970)

jcheng5 and others added 25 commits January 19, 2024 08:55
Extracted out BslibTaskButtonContents and changed it into a
pair of more generic content-switcher custom elements.
Without this, load_all and devtools::document() would fail when called
on the shiny package, saying the required version of bslib was not
found.
Remove set_task_button_manual_reset export, making that behavior implicit
upon update_task_button(state="busy") or update_task_button(state="ready").
Co-authored-by: Garrick Aden-Buie <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
# Conflicts:
#	R/sysdata.rda
#	inst/components/dist/components.css
@gadenbuie
Copy link
Member Author

I made the PR to have CI build our component assets, but that won't work because there are conflicts with main and the PR is merged into main anyway when the assets are created. I'll do it manually and locally instead.

@gadenbuie gadenbuie closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants