-
Notifications
You must be signed in to change notification settings - Fork 65
Updates for py-shiny v0.7.0 #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted out BslibTaskButtonContents and changed it into a pair of more generic content-switcher custom elements.
Without this, load_all and devtools::document() would fail when called on the shiny package, saying the required version of bslib was not found.
Remove set_task_button_manual_reset export, making that behavior implicit upon update_task_button(state="busy") or update_task_button(state="ready").
Co-authored-by: Garrick Aden-Buie <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
# Conflicts: # R/sysdata.rda # inst/components/dist/components.css
Member
Author
|
I made the PR to have CI build our component assets, but that won't work because there are conflicts with main and the PR is merged into main anyway when the assets are created. I'll do it manually and locally instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@examplesIf interactive()devtools::document()(GitHub Actions)grid-columnon md-down (fix(layout_columns): Don't breakgrid-columnon md-down #970)