Fix NULL caller function environment
#582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug in #546 that would manifest when running an app via
shiny::runApp().When the following app is run via
shiny::runApp()it will currently generate an error
due to
runApp()'s use ofeval(). This PR catches the case of the calling function's environment beingNULLand assumes that means the function is not being called from within Shiny. With this PR, when you exit the app, the expected deprecation warnings are printed.You can replace
navs_bar()withtabsetPanel()to verify that the deprecation warnings are appropriately muffled intabsetPanel().(If testing, be sure to run via
shiny::runApp().)