chore: Allow return of component dependency Sass files #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
force-pushed
the
chore/component-deps-as-sass
branch
from
5f143e7 to
cffc4fd
Compare
They're `$select-` prefixed in selectize, so we weren't relying on these
6 tasks
gadenbuie
commented
Jun 12, 2024
cpsievert
reviewed
Jun 13, 2024
gadenbuie
force-pushed
the
chore/component-deps-as-sass
branch
from
455bd78 to
c350108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
component_dependency_sass()returns abs_dependency()where the component's Sass files are compiled against the currenttheme.This change is in support of dynamic theming in Shiny for Python. This PR makes it possible (internally, not in a user-facing way) to request the Sass files that would otherwise be passed to
bs_dependency(input=).Pairs with: