feat(layout_columns): Use sm as the default col_widths breakpoint
#1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with
layout_columns():col_widths = c(12, 6, 6)now becomescol_widths = breakpoints(sm = c(12, 6, 6))where we previously usedmdas the default breakpoint. This update aligns with the intuitive expectation thatcol_widthsof a single value is the column widths at all breakpoints (except mobile where we do something completely different).While here I noticed that we actually do need to include the
xs-specific CSS variable when it's not the only variable being set. Without this change therow_heights = breakpoints(xs = ..., sm = ...)doesn't work as expected.Example app
Current behavior on shinylive.io.